Improve the error tolerance for drop counters test #14676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On T0 testbed, sometimes we observed addtional drops which equals to the number of vlan members.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Sep 30, 2024
On T0 testbed, sometimes we observed addtional drops which equals to the number of vlan members.
|
Cherry-pick PR to 202405: #14800 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Sep 30, 2024
On T0 testbed, sometimes we observed addtional drops which equals to the number of vlan members.
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
On T0 testbed, sometimes we observed addtional drops which equals to the number of vlan members.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
On T0 testbed, sometimes we observed additional drops which equals to the number of vlan members.
Those drops are caused by the background packets in the test environment and should be tolerated in the test.
Type of change
Back port request
Approach
What is the motivation for this PR?
To improve the error tolerance for drop counters test.
How did you do it?
Increase the DROP_MARGIN to the number of vlan members for t0 topology.
How did you verify/test it?
Run the test in our regression for weeks, it is passing.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation